-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align cards vertically in small screen size in our projects section #1622
Align cards vertically in small screen size in our projects section #1622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can't edit the argon.css file. @anjula-sack Can we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the preview link? @Isuru4043
You should include the pr number except this {PR_NUMBER}
Ex: https://pr-0000-sef-site.surge.sh/
@YoshithaRathnayake sure, I'll update the preview link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are good! @Isuru4043 Thank you but I can't merge this bcs I don't know whether we can't change the argon.css file. I will ask from anjula ayya. @anjula-sack ?
You are correct @YoshithaRathnayake. We shouldn't be updating argon.css file. @Isuru4043 Can you override it on the relevant CSS file? |
Can we change the global-custom.css file. @anjula-sack |
Yeah you can @Isuru4043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any updates? @Isuru4043
Purpose
The purpose of this PR is to fix #1621
Goals
Vertically aligning cards where words were confused in small screen size.
Approach
Change the min-width from 576px to 768px in media query.
Screenshots
before
after
Preview Link
https://pr-1622-sef-site.surge.sh/
Checklist
Related PRs
Learning