Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align cards vertically in small screen size in our projects section #1622

Closed

Conversation

Isuru4043
Copy link
Contributor

@Isuru4043 Isuru4043 commented May 7, 2024

Purpose

The purpose of this PR is to fix #1621

Goals

Vertically aligning cards where words were confused in small screen size.

Approach

Change the min-width from 576px to 768px in media query.

Screenshots

before
F-2
F-1

after
f-4
f-3

Preview Link

https://pr-1622-sef-site.surge.sh/

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Related PRs

Learning

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can't edit the argon.css file. @anjula-sack Can we?

@YoshithaRathnayake YoshithaRathnayake changed the title align cards vertically in small screen size in our projects section. Align cards vertically in small screen size in our projects section May 7, 2024
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the preview link? @Isuru4043
You should include the pr number except this {PR_NUMBER}
Ex: https://pr-0000-sef-site.surge.sh/

@Isuru4043
Copy link
Contributor Author

@YoshithaRathnayake sure, I'll update the preview link.

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good! @Isuru4043 Thank you but I can't merge this bcs I don't know whether we can't change the argon.css file. I will ask from anjula ayya. @anjula-sack ?

@anjula-sack
Copy link
Member

The changes are good! @Isuru4043 Thank you but I can't merge this bcs I don't know whether we can't change the argon.css file. I will ask from anjula ayya. @anjula-sack ?

You are correct @YoshithaRathnayake. We shouldn't be updating argon.css file. @Isuru4043 Can you override it on the relevant CSS file?

@Isuru4043
Copy link
Contributor Author

Isuru4043 commented May 11, 2024

Can we change the global-custom.css file. @anjula-sack

@YoshithaRathnayake
Copy link
Member

Can we change the global-custom.css file. @anjula-sack

Yeah you can @Isuru4043

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates? @Isuru4043

@Isuru4043 Isuru4043 closed this Jul 28, 2024
@Isuru4043 Isuru4043 deleted the allign-our-projects-section branch July 28, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the Our projects section within small screen size.
3 participants