Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the image size of onelive page #1613

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

Dilini-457
Copy link
Contributor

@Dilini-457 Dilini-457 commented Jan 17, 2024

Purpose

The purpose of this PR is to fix #1478

Goals

  • Reduce image size of onelive page

Approach

  • Reduce viewport height

Screenshots

image

Preview Link

https://pr-1613-sef-site.surge.sh/onelive

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the directory name for the preview link? So it is easy for the reviewers @Dilini-457
Eg: {preview_link}/onelive

And add a screenshot of the change you have done!

Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thank you! @Dilini-457

@YoshithaRathnayake YoshithaRathnayake merged commit 3ab3a4d into sef-global:master Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the image size of OneLive page
2 participants