-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Learn More button redirecting problem on the Join Us page #1617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YoshithaRathnayake Can you check and review my PR.
@RamithaHeshan33 Can you drop a message on the relevant issue so i can assign you? |
No problem in the PR btw, just put a comment on the issue to be assigned to this issue as @anjula-sack said @RamithaHeshan33 Development Best Practises If you read this you will find that first of all you should be assigned for a issue, bcs this is your first time its ok so just go to the issue and drop a comment that you are working on it! |
Sure @anjula-sack. I created this pull request for issue number #1612 (Fix the "Learn More" button link on the Join Us page opening in the same page) I will add a screenshot of the issue below to make the problem more clear. Before Fixing the Issuebefore.mp4After Fixing the Issueafter.mp4 |
Thanks for the reviewing PR @YoshithaRathnayake. Yes, it was my first time. Sorry for putting a pull request before assigning and Thank you for your guidance. |
No problem @RamithaHeshan33 |
So can you drop a comment in the issue #1612 otherwise I won't be able to assign you for the issue @RamithaHeshan33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Thank You! @RamithaHeshan33
Purpose
Fixing the issue of "Learn More" button on the Join Us page opening in the same page #1612
Goals
After clicking the "Learn More" button handbook will open from new tab
Approach
Modified the "join-us.html" file. I used the attribute called "target='_blank' "
Screenshots
Preview Link
https://pr-1617-sef-site.surge.sh/
Checklist