Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some flaky tests in the build as well as the case when tests start before kafka is ready #1349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nachogiljaldo
Copy link

@nachogiljaldo nachogiljaldo commented Nov 15, 2024

This PR fixes at least 1 flaky test and a scenario when kafka is slow to start and the first tests in the suite just fail.

The cases are various but we have:

  • topic creating not waiting before sending and reading
  • timeouts
  • kafka not started

I don't think this has solved them all, but I managed to get a local build passing as well as in CI, which I could not achieve without these changes.

@nachogiljaldo nachogiljaldo force-pushed the fix_flaky_tests_and_slow_kafka branch from fb863b8 to de34fb8 Compare November 15, 2024 22:48
@nachogiljaldo nachogiljaldo marked this pull request as ready for review November 15, 2024 22:56
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@nachogiljaldo
Copy link
Author

@jkoelker / @erikdw apologies for pinging you directly, but I see you reviewed the last 4 PRs that were merged.

I found that it was impossible to get a green build while working on ht ttps://github.com//pull/1330 (which would also need some review) and decided to add this PR to address those flaky tests.

I see main is currently broken, so hopefully this would help with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant