-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add placeholder api conditions support #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive never used the placeholder api so ill have to test it out later, though just the log comment for now :D
spigot/src/main/java/com/sekwah/advancedportals/spigot/AdvancedPortalsPlugin.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry wrong review type, meant to request the change
dbb73f6
to
98e2341
Compare
spigot/src/main/java/com/sekwah/advancedportals/spigot/tags/ConditionsTag.java
Show resolved
Hide resolved
spigot/src/main/java/com/sekwah/advancedportals/spigot/tags/ConditionsTag.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im happy with the changes, just check out if you want to make any changes based on the comment someone else made :D
Good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a rebase :)
017efe7
to
35fb37c
Compare
Allows admins to select specific clauses for when a portal can be used / not be used.
35fb37c
to
35ed596
Compare
Allows admins to select specific clauses for when a portal can be used / not be used.
#434 is related, although it can be done better.