Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add placeholder api conditions support #501

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

TreemanKing
Copy link
Contributor

Allows admins to select specific clauses for when a portal can be used / not be used.

#434 is related, although it can be done better.

Copy link
Owner

@sekwah41 sekwah41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive never used the placeholder api so ill have to test it out later, though just the log comment for now :D

Copy link
Owner

@sekwah41 sekwah41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry wrong review type, meant to request the change

Copy link
Owner

@sekwah41 sekwah41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im happy with the changes, just check out if you want to make any changes based on the comment someone else made :D

@TreemanKing
Copy link
Contributor Author

Im happy with the changes, just check out if you want to make any changes based on the comment someone else made :D

Good to go now.

Copy link
Owner

@sekwah41 sekwah41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase :)

@TreemanKing TreemanKing force-pushed the conditions branch 2 times, most recently from 017efe7 to 35fb37c Compare December 29, 2024 07:08
Allows admins to select specific clauses for when a portal can be used / not be used.
@sekwah41 sekwah41 merged commit 38a0d14 into sekwah41:main Dec 31, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants