Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifactory #3122

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Artifactory #3122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5cf6c8e
Changed artifactory to be regex and remove common fps
LewisArdern Sep 20, 2023
5fb332b
remove shield
LewisArdern Sep 20, 2023
6b847b1
move back current rule
LewisArdern Sep 20, 2023
6a11466
fix test
LewisArdern Sep 20, 2023
165390a
Merge branch 'develop' into artifactory
kurt-r2c Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generic/secrets/gitleaks/generic-api-key.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,4 +207,4 @@ clientToken: "pub4306832bdc5f2b8b980c492ec2c11ef3",
// ok: generic-api-key
keys: 'privkey1.json',
// ok: generic-api-key
"Keywords": "asdsadsadsaUSAdusadusadsa",
"Keywords": "asdsadsadsaUSAdusadusadsa",
LewisArdern marked this conversation as resolved.
Show resolved Hide resolved
13 changes: 2 additions & 11 deletions generic/secrets/security/detected-artifactory-password.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
# ruleid: detected-artifactory-password
AP6xxxxxxxxxx

# ruleid: detected-artifactory-password
AP2xxxxxxxxxx

# ruleid: detected-artifactory-password
artifactoryx:_password=AP6xxxxxxxxxx
artifactoryx:_password=AP6abc1231321

# ok: detected-artifactory-password
integrity sha512-AP1AyUTbi2szylgr+O0OB7gkIxEGzySLITZ2GpsaoX72YMCGI2jYAc+WUhPfvUnZYiauF4zTnN4V4TGuvFjJlw==
Expand All @@ -19,9 +13,6 @@ ImageID: "SHA256:AP1AyUTbi2szylgr266fcae00707e67a2545ef34f9a29354585f93dac906749
# ok: detected-artifactory-password
- hasql-1.6.0.1@sha256:AP1AyUTbi2szylgr+422a3bb776a12d5cf2bb83303778f343106f9a1cc2b4fcdf73,6628

# ruleid: detected-artifactory-password
artifactoryx_password:AP6xxxxxxxxxx

# ok: detected-artifactory-password
X-JFrog-Art-Api: $PASSWORD

Expand Down Expand Up @@ -124,7 +115,7 @@ b3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KIHRoaXMgc29mdHdhcmUgd2l0aG9

-----BEGIN PGP PUBLIC KEY BLOCK-----
# ok: detected-artifactory-password
AP6xxxxxxxxxx
AP6abc1231321
-----END PGP PUBLIC KEY BLOCK-----

apiVersion: appprotectdos.f5.com/v1beta1
Expand Down
31 changes: 6 additions & 25 deletions generic/secrets/security/detected-artifactory-password.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,16 @@
rules:
- id: detected-artifactory-password
options:
generic_engine: aliengrep
generic_multiline: false
generic_caseless: true
patterns:
- pattern: $ITEM
- metavariable-regex:
metavariable: $ITEM
regex: \bAP[\dABCDEF][a-zA-Z0-9]{8,}
- pattern-not-inside: |
sha1...
- pattern-not-inside: |
sha2...
- pattern-not-inside: |
sha3...
- pattern-not-inside: |
sha118...
- pattern-not-inside: |
sha256...
- pattern-not-inside: |
sha512...
- pattern-not-inside: |
-BEGIN ...-
....
...-END ...-
- pattern-regex: (?<ITEM>\bAP[\dABCDEF][a-zA-Z0-9]{8,})
- pattern-regex: .*(?i)arti[-_]?factory.*
- pattern-not-regex: .*(?i)sha(1|2|3|118|256|512).*
- pattern-not-regex: (?i)-----\s*?BEGIN[ A-Z0-9_-]*? KEY( BLOCK)?-----[\s\S]*?-----\s*?END[ A-Z0-9_-]*?\s*?-----
- metavariable-analysis:
analyzer: entropy
metavariable: $ITEM
- pattern-not-regex: (\w|\.|\*)\1{4}
languages:
- generic
- regex
paths:
exclude:
- "*.svg"
Expand Down