feat(core): enable user custom check flows #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split `create_rav_request` to let the user execute checks entirely themselves. This enables running batched checks before a RAV request. Signed-off-by: Alexis Asseman <[email protected]>
|
🤖 Cargo Audit Report 🤖 (Empty means OK! 👍) |
|
Decided to leave it as a draft, I'm not sure it makes sense to push this to main. I'll use this branch with the indexer-service for now to try and make some progress, but ideally we come up with a better solution later on. |
|
Abandoned in favor of #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
create_rav_requestto let the user execute checks entirely themselves. This enables running batched checks before a RAV request.This kinda breaks the encapsulation, but I couldn't figure out anything better that fits my needs in https://github.com/graphops/indexer-service-rs for now...