Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sf-protos): clean up sf protos #12

Conversation

@suchapalaver suchapalaver self-assigned this Oct 21, 2024
Copy link

linear bot commented Oct 21, 2024

BACK-73 Clean up sf-protos

Clean up the sf-protos crate. Do not add new features.

  • Any new public functions should be tested.
  • Any new public functions should be documented.

You are responsible for propagating any name changes you make.

This comment has been minimized.

@suchapalaver suchapalaver force-pushed the joseph/back-73-clean-up-sf-protos branch 2 times, most recently from 972bc44 to c765441 Compare October 21, 2024 16:11

This comment has been minimized.

@suchapalaver suchapalaver force-pushed the joseph/back-73-clean-up-sf-protos branch from c765441 to 3bbe29c Compare October 21, 2024 16:33
@suchapalaver suchapalaver marked this pull request as ready for review October 21, 2024 16:43
@suchapalaver suchapalaver requested a review from anirudh2 October 21, 2024 16:44
Copy link

🤖 Cargo Audit Report 🤖

Crate: object_store
Version: 0.9.1
Title: Apache Arrow Rust Object Store: AWS WebIdentityToken exposure in log files
Date: 2024-07-23
ID: RUSTSEC-2024-0358
URL: https://rustsec.org/advisories/RUSTSEC-2024-0358
Severity: 3.8 (low)
Solution: Upgrade to >=0.10.2
Dependency tree:
object_store 0.9.1
└── flat-head 0.1.0

Crate: ansi_term
Version: 0.12.1
Warning: unmaintained
Title: ansi_term is Unmaintained
Date: 2021-08-18
ID: RUSTSEC-2021-0139
URL: https://rustsec.org/advisories/RUSTSEC-2021-0139
Dependency tree:
ansi_term 0.12.1
└── trin-utils 0.1.1-alpha.1
└── ethportal-api 0.2.2
├── trin-validation 0.1.0
│ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── flat-head 0.1.0
├── sf-protos 0.1.0
│ ├── header_accumulator 0.1.0
│ ├── forrestrie 0.1.0
│ ├── flat-head 0.1.0
│ ├── firehose-client 0.1.0
│ │ └── forrestrie 0.1.0
│ └── decoder 0.1.1
│ ├── header_accumulator 0.1.0
│ └── flat-head 0.1.0
├── header_accumulator 0.1.0
└── forrestrie 0.1.0

Crate: atty
Version: 0.2.14
Warning: unmaintained
Title: atty is unmaintained
Date: 2024-09-25
ID: RUSTSEC-2024-0375
URL: https://rustsec.org/advisories/RUSTSEC-2024-0375
Dependency tree:
atty 0.2.14
└── trin-utils 0.1.1-alpha.1
└── ethportal-api 0.2.2
├── trin-validation 0.1.0
│ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── flat-head 0.1.0
├── sf-protos 0.1.0
│ ├── header_accumulator 0.1.0
│ ├── forrestrie 0.1.0
│ ├── flat-head 0.1.0
│ ├── firehose-client 0.1.0
│ │ └── forrestrie 0.1.0
│ └── decoder 0.1.1
│ ├── header_accumulator 0.1.0
│ └── flat-head 0.1.0
├── header_accumulator 0.1.0
└── forrestrie 0.1.0

Crate: dotenv
Version: 0.15.0
Warning: unmaintained
Title: dotenv is Unmaintained
Date: 2021-12-24
ID: RUSTSEC-2021-0141
URL: https://rustsec.org/advisories/RUSTSEC-2021-0141
Dependency tree:
dotenv 0.15.0
└── flat-head 0.1.0

Crate: proc-macro-error
Version: 1.0.4
Warning: unmaintained
Title: proc-macro-error is unmaintained
Date: 2024-09-01
ID: RUSTSEC-2024-0370
URL: https://rustsec.org/advisories/RUSTSEC-2024-0370
Dependency tree:
proc-macro-error 1.0.4
├── validator_derive 0.13.0
│ └── validator 0.13.0
│ └── ethportal-api 0.2.2
│ ├── trin-validation 0.1.0
│ │ ├── header_accumulator 0.1.0
│ │ │ └── flat-head 0.1.0
│ │ └── flat-head 0.1.0
│ ├── sf-protos 0.1.0
│ │ ├── header_accumulator 0.1.0
│ │ ├── forrestrie 0.1.0
│ │ ├── flat-head 0.1.0
│ │ ├── firehose-client 0.1.0
│ │ │ └── forrestrie 0.1.0
│ │ └── decoder 0.1.1
│ │ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ ├── header_accumulator 0.1.0
│ └── forrestrie 0.1.0
├── alloy-sol-macro-expander 0.7.7
│ └── alloy-sol-macro 0.7.7
│ └── alloy-sol-types 0.7.7
│ ├── alloy-rpc-types-eth 0.1.4
│ │ ├── reth-primitives-traits 1.0.1
│ │ │ ├── reth-trie-common 1.0.1
│ │ │ │ ├── reth-primitives 1.0.1
│ │ │ │ │ ├── sf-protos 0.1.0
│ │ │ │ │ └── decoder 0.1.1
│ │ │ │ └── decoder 0.1.1
│ │ │ └── reth-primitives 1.0.1
│ │ └── alloy-rpc-types 0.1.4
│ │ └── reth-primitives 1.0.1
│ └── alloy-rpc-types 0.1.0
│ ├── reth-rpc-types 0.2.0-beta.5
│ │ └── ethportal-api 0.2.2
│ ├── alloy-rpc-types-trace 0.1.0
│ │ └── reth-rpc-types 0.2.0-beta.5
│ └── alloy-rpc-types-engine 0.1.0
│ └── reth-rpc-types 0.2.0-beta.5
└── alloy-sol-macro 0.7.7

Crate: atty
Version: 0.2.14
Warning: unsound
Title: Potential unaligned read
Date: 2021-07-04
ID: RUSTSEC-2021-0145
URL: https://rustsec.org/advisories/RUSTSEC-2021-0145

warning: 5 allowed warnings found

(Empty means OK! 👍)

anirudh2
anirudh2 previously approved these changes Oct 21, 2024
@suchapalaver suchapalaver force-pushed the joseph/back-73-clean-up-sf-protos branch from 3bbe29c to 1aa9aaf Compare October 21, 2024 17:57
@suchapalaver suchapalaver requested a review from anirudh2 October 21, 2024 17:58
@suchapalaver suchapalaver enabled auto-merge (rebase) October 21, 2024 17:58
@suchapalaver suchapalaver force-pushed the joseph/back-73-clean-up-sf-protos branch from 1aa9aaf to 5c21d52 Compare October 21, 2024 18:09
@suchapalaver suchapalaver force-pushed the joseph/back-73-clean-up-sf-protos branch from 5c21d52 to a8182ee Compare October 21, 2024 18:19
@suchapalaver suchapalaver changed the base branch from main to gustavo/back-64-create-a-documentation-site-for-veemon October 21, 2024 18:20
@suchapalaver suchapalaver merged commit df6fba1 into gustavo/back-64-create-a-documentation-site-for-veemon Oct 21, 2024
7 checks passed
@suchapalaver suchapalaver deleted the joseph/back-73-clean-up-sf-protos branch October 21, 2024 18:20
@suchapalaver suchapalaver restored the joseph/back-73-clean-up-sf-protos branch October 21, 2024 18:22
@suchapalaver suchapalaver deleted the joseph/back-73-clean-up-sf-protos branch October 21, 2024 22:01
suchapalaver added a commit that referenced this pull request Nov 28, 2024
…con-block-header-and-beacon-block-roots-match

test(beacon_block): test header root and block root match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants