refactor(header-accumulator): clean up README #55
+42
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchapalaver
force-pushed
the
joseph/back-154-edit-the-header-accumulator-readmemd
branch
from
5d8d4bb to
b2436ee
Compare
pedrohba1
reviewed
Nov 6, 2024
|
|
||
| Generate code coverage reports with `cargo llvm-cov --html` and open them with `open ./target/llvm-cov/html/index.html`. |
There was a problem hiding this comment.
Could we keep this line about coverage? There are many ways to do it and it is good not having to remember it by head.
Alternatively, we can add it to CI and have those cool badges that show info on coverage.
There was a problem hiding this comment.
Yeah, I agree we should keep the knowledge. I just don't think this is the right place for it. Let's create an issue for your CI idea.
There was a problem hiding this comment.
Here's the issue: https://linear.app/semiotic/issue/BACK-155/code-coverage-reports
pedrohba1
approved these changes
Nov 6, 2024
suchapalaver
deleted the
joseph/back-154-edit-the-header-accumulator-readmemd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.