Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forrestrie): fix historical summaries index in PoC example #6

Conversation

suchapalaver
Copy link
Contributor

@suchapalaver suchapalaver self-assigned this Oct 18, 2024
Copy link

linear bot commented Oct 18, 2024

BACK-54 `veemon/forrestrie`: fix historical summaries index in example

  • Which version(s)?

    N/A

  • How to reproduce the bug?

    Try to run the example on main (this would require an API key from Pinax in a .env file - this is at least documented).

  • Current behavior?

    The inclusion proof verification fails.

  • Expected behavior?

    • The inclusion proof verification passes.
  • Additional information and links (optional):

    Made an oopsie when copying code over this week.

Note: As needed, the discussion on the best ways to resolve the bug can be done through comments on the task, and tagging the people and teams possibly related.

This comment has been minimized.

@suchapalaver suchapalaver force-pushed the joseph/back-54-veemonforrestrie-fix-historical-summaries-index-in-example branch from 5eab485 to 45f4506 Compare October 18, 2024 21:02

This comment has been minimized.

@suchapalaver suchapalaver changed the base branch from main to joseph/back-53-veemonfirehose-client-fix-client-for-use-with-api-keys October 18, 2024 21:05
@suchapalaver suchapalaver force-pushed the joseph/back-53-veemonfirehose-client-fix-client-for-use-with-api-keys branch from 62e7318 to b7d6886 Compare October 18, 2024 21:17
@suchapalaver suchapalaver force-pushed the joseph/back-54-veemonforrestrie-fix-historical-summaries-index-in-example branch from 45f4506 to da27dfe Compare October 18, 2024 21:19

This comment has been minimized.

@suchapalaver suchapalaver force-pushed the joseph/back-54-veemonforrestrie-fix-historical-summaries-index-in-example branch from da27dfe to e6af2a5 Compare October 18, 2024 21:23

This comment has been minimized.

Base automatically changed from joseph/back-53-veemonfirehose-client-fix-client-for-use-with-api-keys to main October 21, 2024 13:36
@suchapalaver suchapalaver force-pushed the joseph/back-54-veemonforrestrie-fix-historical-summaries-index-in-example branch from e6af2a5 to 48a424d Compare October 21, 2024 13:48
@suchapalaver suchapalaver marked this pull request as ready for review October 21, 2024 13:49
Copy link

🤖 Cargo Audit Report 🤖

Crate: object_store
Version: 0.9.1
Title: Apache Arrow Rust Object Store: AWS WebIdentityToken exposure in log files
Date: 2024-07-23
ID: RUSTSEC-2024-0358
URL: https://rustsec.org/advisories/RUSTSEC-2024-0358
Severity: 3.8 (low)
Solution: Upgrade to >=0.10.2
Dependency tree:
object_store 0.9.1
└── flat-head 0.1.0

Crate: ansi_term
Version: 0.12.1
Warning: unmaintained
Title: ansi_term is Unmaintained
Date: 2021-08-18
ID: RUSTSEC-2021-0139
URL: https://rustsec.org/advisories/RUSTSEC-2021-0139
Dependency tree:
ansi_term 0.12.1
└── trin-utils 0.1.1-alpha.1
└── ethportal-api 0.2.2
├── trin-validation 0.1.0
│ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── flat-head 0.1.0
├── sf-protos 0.1.0
│ ├── header_accumulator 0.1.0
│ ├── forrestrie 0.1.0
│ ├── flat-head 0.1.0
│ ├── firehose-client 0.1.0
│ │ └── forrestrie 0.1.0
│ └── decoder 0.1.1
│ ├── header_accumulator 0.1.0
│ └── flat-head 0.1.0
├── header_accumulator 0.1.0
└── forrestrie 0.1.0

Crate: atty
Version: 0.2.14
Warning: unmaintained
Title: atty is unmaintained
Date: 2024-09-25
ID: RUSTSEC-2024-0375
URL: https://rustsec.org/advisories/RUSTSEC-2024-0375
Dependency tree:
atty 0.2.14
└── trin-utils 0.1.1-alpha.1
└── ethportal-api 0.2.2
├── trin-validation 0.1.0
│ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── flat-head 0.1.0
├── sf-protos 0.1.0
│ ├── header_accumulator 0.1.0
│ ├── forrestrie 0.1.0
│ ├── flat-head 0.1.0
│ ├── firehose-client 0.1.0
│ │ └── forrestrie 0.1.0
│ └── decoder 0.1.1
│ ├── header_accumulator 0.1.0
│ └── flat-head 0.1.0
├── header_accumulator 0.1.0
└── forrestrie 0.1.0

Crate: dotenv
Version: 0.15.0
Warning: unmaintained
Title: dotenv is Unmaintained
Date: 2021-12-24
ID: RUSTSEC-2021-0141
URL: https://rustsec.org/advisories/RUSTSEC-2021-0141
Dependency tree:
dotenv 0.15.0
└── flat-head 0.1.0

Crate: proc-macro-error
Version: 1.0.4
Warning: unmaintained
Title: proc-macro-error is unmaintained
Date: 2024-09-01
ID: RUSTSEC-2024-0370
URL: https://rustsec.org/advisories/RUSTSEC-2024-0370
Dependency tree:
proc-macro-error 1.0.4
├── validator_derive 0.13.0
│ └── validator 0.13.0
│ └── ethportal-api 0.2.2
│ ├── trin-validation 0.1.0
│ │ ├── header_accumulator 0.1.0
│ │ │ └── flat-head 0.1.0
│ │ └── flat-head 0.1.0
│ ├── sf-protos 0.1.0
│ │ ├── header_accumulator 0.1.0
│ │ ├── forrestrie 0.1.0
│ │ ├── flat-head 0.1.0
│ │ ├── firehose-client 0.1.0
│ │ │ └── forrestrie 0.1.0
│ │ └── decoder 0.1.1
│ │ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ ├── header_accumulator 0.1.0
│ └── forrestrie 0.1.0
├── alloy-sol-macro-expander 0.7.7
│ └── alloy-sol-macro 0.7.7
│ └── alloy-sol-types 0.7.7
│ ├── alloy-rpc-types-eth 0.1.4
│ │ ├── reth-primitives-traits 1.0.1
│ │ │ ├── reth-trie-common 1.0.1
│ │ │ │ ├── reth-primitives 1.0.1
│ │ │ │ │ ├── sf-protos 0.1.0
│ │ │ │ │ └── decoder 0.1.1
│ │ │ │ └── decoder 0.1.1
│ │ │ └── reth-primitives 1.0.1
│ │ └── alloy-rpc-types 0.1.4
│ │ └── reth-primitives 1.0.1
│ └── alloy-rpc-types 0.1.0
│ ├── reth-rpc-types 0.2.0-beta.5
│ │ └── ethportal-api 0.2.2
│ ├── alloy-rpc-types-trace 0.1.0
│ │ └── reth-rpc-types 0.2.0-beta.5
│ └── alloy-rpc-types-engine 0.1.0
│ └── reth-rpc-types 0.2.0-beta.5
└── alloy-sol-macro 0.7.7

Crate: atty
Version: 0.2.14
Warning: unsound
Title: Potential unaligned read
Date: 2021-07-04
ID: RUSTSEC-2021-0145
URL: https://rustsec.org/advisories/RUSTSEC-2021-0145

warning: 5 allowed warnings found

(Empty means OK! 👍)

@suchapalaver
Copy link
Contributor Author

@gusinacio , I included the fixes you suggested in a previous PR here as well 👍

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suchapalaver suchapalaver merged commit 8ea5efa into main Oct 21, 2024
7 checks passed
@suchapalaver suchapalaver deleted the joseph/back-54-veemonforrestrie-fix-historical-summaries-index-in-example branch October 21, 2024 14:02
suchapalaver added a commit that referenced this pull request Nov 28, 2024
docs(README): add notes on documentation and resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants