fix unstable test、mild fix log level (#85)

* fix unstable test * mild fix log level * add release description by job
sensuikan1973 · Mar 20, 2021 · c2ae9d7 · c2ae9d7
1 parent add7575
commit c2ae9d7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -77,3 +77,6 @@ jobs:
           draft: true
           tag_name: ${{ github.event.inputs.tag }}
           files: ${{ env.PUBLISH_DIR }}/pedax-${{ runner.os }}.zip
+          # See: https://docs.github.com/ja/actions/reference/environment-variables
+          body: |-
+            This release is created by $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID.
diff --git a/lib/engine/edax_server.dart b/lib/engine/edax_server.dart
@@ -69,7 +69,7 @@ class EdaxServer {
 
     // ignore: avoid_annotating_with_dynamic
     _receivePort.listen((dynamic message) async {
-      logger.i('received request "${message.runtimeType}"');
+      logger.d('received request "${message.runtimeType}"');
       if (message is MoveRequest) {
         parentSendPort.send(executeMove(edax, message));
       } else if (message is PlayRequest) {
@@ -83,7 +83,7 @@ class EdaxServer {
             continue;
           }
           if (_latestHintMessage.movesAtRequest != message.movesAtRequest) {
-            logger.i(
+            logger.d(
                 'The HintOneByOneRequest (moves: ${message.movesAtRequest}) has dropped.\nIt is because a new HintOneByOneRequest (moves: ${_latestHintMessage.movesAtRequest}) has been received after that.');
             break;
           }

diff --git a/lib/home/home.dart b/lib/home/home.dart
@@ -161,6 +161,7 @@ class _HomeState extends State<Home> {
     context.read<BoardNotifier>().finishedNotifyingBookHasLoadedToUser();
     WidgetsBinding.instance?.addPostFrameCallback((_) async {
       await Future<void>.delayed(const Duration(seconds: 1));
+      if (!mounted) return;
       ScaffoldMessenger.of(context).removeCurrentSnackBar();
       ScaffoldMessenger.of(context).showSnackBar(
         SnackBar(
@@ -173,6 +174,7 @@ class _HomeState extends State<Home> {
   void _showSnackBarOfBookLoading() {
     context.read<BoardNotifier>().finishedNotifyingBookHasLoadedToUser();
     WidgetsBinding.instance?.addPostFrameCallback((_) {
+      if (!mounted) return;
       ScaffoldMessenger.of(context).removeCurrentSnackBar();
       ScaffoldMessenger.of(context).showSnackBar(
         SnackBar(

diff --git a/lib/models/board_notifier.dart b/lib/models/board_notifier.dart
@@ -112,7 +112,7 @@ class BoardNotifier extends ValueNotifier<BoardState> {
 
   // ignore: avoid_annotating_with_dynamic
   Future<void> _updateStateByEdaxServerResponse(dynamic message) async {
-    _logger.i('received response "${message.runtimeType}"');
+    _logger.d('received response "${message.runtimeType}"');
     if (message is MoveResponse) {
       if (value.currentMoves != message.moves) _requestLatestHintList(message.moves);
       value