Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] libc++ support #3209

Merged
merged 13 commits into from
Nov 13, 2023
Merged

[FEATURE] libc++ support #3209

merged 13 commits into from
Nov 13, 2023

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Nov 12, 2023

Resolves #3207

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 9:18am

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 12, 2023
@eseiler
[FIX] libc++: binding to bitfield
7252735 
non-const reference cannot bind to bit-field 'mapq'
@eseiler
[FIX] libc++: linker error
ce75ce1
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 12, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b0b55f) 98.14% compared to head (e2dd179) 98.17%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3209      +/-   ##
==========================================
+ Coverage   98.14%   98.17%   +0.03%     
==========================================
  Files         269      269              
  Lines       11855    11852       -3     
==========================================
+ Hits        11635    11636       +1     
+ Misses        220      216       -4
Files Coverage Δ
...ude/seqan3/core/debug_stream/debug_stream_type.hpp 92.30% <ø> (+15.38%) ⬆️
include/seqan3/io/sam_file/format_bam.hpp 94.55% <100.00%> (ø)
include/seqan3/io/sequence_file/format_embl.hpp 100.00% <100.00%> (ø)
include/seqan3/io/sequence_file/format_fasta.hpp 95.68% <100.00%> (ø)
include/seqan3/io/sequence_file/format_fastq.hpp 92.03% <100.00%> (ø)
include/seqan3/io/sequence_file/format_genbank.hpp 100.00% <100.00%> (ø)
...qan3/io/stream/detail/fast_istreambuf_iterator.hpp 100.00% <100.00%> (ø)
...clude/seqan3/search/detail/search_configurator.hpp 96.77% <100.00%> (-0.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 13, 2023
SGSSGene
SGSSGene approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@eseiler eseiler merged commit fc8f4f7 into seqan:master Nov 13, 2023
26 checks passed
@eseiler eseiler deleted the infra/ci_libc++ branch November 13, 2023 10:37
@eseiler eseiler mentioned this pull request Nov 13, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGSSGene SGSSGene SGSSGene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libc++] std::result_of_t was removed in C++20
3 participants
@eseiler @SGSSGene @seqan-actions