[FIX] libc++: header tests #3210
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3210 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 269 269
Lines 11852 11852
=======================================
Hits 11636 11636
Misses 216 216 ☔ View full report in Codecov by Sentry. |
| #include <iosfwd> | ||
| #include <ostream> |
There was a problem hiding this comment.
This now counter-acts the purpose of a lightweight debug_stream_type?
There was a problem hiding this comment.
Kind of
I can do different includes for libstdc++ (gcc) and libc++ (llvm) :D
There was a problem hiding this comment.
there is no iosfw equivalent for libc++?
I would vote for different includes then :)
There was a problem hiding this comment.
I'll have to check what the issue was, but we are accessing stuff that requires a defined std::ostream. Whatever we need is apparently in <iosfwd> for libstdc++, but not in libc++
There was a problem hiding this comment.
Actually, we don't need <ostream> here, but in pretty_printing.hpp.
So, good catch 👍
eseiler
force-pushed
the
infra/header
branch
from
7199ebb to
b447e2f
Compare
seqan-actions
added
lint
No description provided.