Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/copyrightyear update #3229

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Conversation

SGSSGene
Copy link
Contributor

Update all license text to SPDX-headers and include a new CI job, which checks for valid SPDX information.

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview Jan 30, 2024 10:22am

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 30, 2024
@SGSSGene SGSSGene force-pushed the patch/copyrightyear_update branch from 2925e3c to 2115ba9 Compare January 30, 2024 09:47
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 30, 2024
@@ -1,3 +1,6 @@
# SPDX-FileCopyrightText: 2006-2024 Knut Reinert & Freie Universität Berlin
# SPDX-FileCopyrightText: 2016-2024 Knut Reinert & MPI für molekulare Genetik
# SPDX-License-Identifier: CC0-1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a new line? The submodules aren't checked out in the ci

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this doesn't seem to work like this at all :/ added a .gitmodules.license

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some commit removed the submodules/* directories. I tried readding them

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 30, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 30, 2024
@SGSSGene SGSSGene force-pushed the patch/copyrightyear_update branch from 2bcb0a4 to c0cb991 Compare January 30, 2024 10:10
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 30, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31fc76e) 98.17% compared to head (182a7d3) 98.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3229   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         269      269           
  Lines       11854    11854           
=======================================
  Hits        11638    11638           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler
Copy link
Member

eseiler commented Jan 30, 2024

We should also update our LICENSE.md and check the install/package script. But this should be a follow-up :)

@eseiler eseiler merged commit 5c321ec into seqan:master Jan 30, 2024
31 checks passed
@SGSSGene SGSSGene deleted the patch/copyrightyear_update branch January 30, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants