Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Improve error message when using kmer_hash_view with invalid shapes #3244

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Feb 28, 2024

Related to #3242 and #3243

Example output:

terminate called after throwing an instance of 'std::invalid_argument'
  what():  The shape is too long for the given alphabet.
Alphabet: seqan3::dna4
Maximum shape count: 32
Given shape count: 33
Aborted

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview Feb 28, 2024 11:50am

@eseiler eseiler requested a review from SGSSGene February 28, 2024 11:11
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 28, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (3e63456) to head (79ea4ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3244   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         269      269           
  Lines       11856    11868   +12     
=======================================
+ Hits        11640    11652   +12     
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 28, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 28, 2024
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, very nice!

@eseiler eseiler merged commit c44d090 into seqan:main Feb 28, 2024
34 checks passed
@eseiler eseiler deleted the misc/improve_error branch February 28, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants