Add Marin County Scraper #80
Conversation
…ight element and clicked on the right elt, but nothing downloaded. switching methods anyway, so going to scrap this code
…and raised exceptions
… are pulled, and put in get_data_model function that Elaine wrote
…bayarea into marin-county
There was a problem hiding this comment.
Started this before we talked tonight, so we already mentioned a few things.
Can you also please make sure to use 4-space (not tab) indentation, so this is consistent with the other files? (If your editor has a plugin for editorconfig, you can install that and it should autoconfigure its indentation settings, etc. for this project.)
changed method name to get_county() Co-authored-by: Rob Brackett <[email protected]>
…operly use the scraper script
….py just wasn't waiting long enough..
… scraper is ready for second round of review.
|
@Mr0grog Hi Rob, whenever you get the chance, would love it if you could review this for the second time! (edit: I think we're probably good, since Elaine went ahead and reviewed it) As I mentioned in the comment, currently I'm not able to scrape the test csv data so I've just commented that line out for now. Edit: as mentioned below, I'll just be able to scrape the time series for positive tests + cumulative number of positive tests. I guess Marin County might have removed the count of negative tests altogether? |
"raise ValueError" to "return Value Error" Co-authored-by: Elaine Laguerta <[email protected]>
…unty moving forward
|
Thank you @elaguerta and @ldtcooper for your comments! @elaguerta unfortunately the original negative/positive breakdown for tests is gone, but I'll go ahead and populate the date/positive/cumul_pos since that's what I can scrape from the graph you linked. Thanks for the update! |
|
@elaguerta I think I covered all of your requested changes, and made sure that I used 4 space indents like Rob requested above. I also added some discussion points in our data fetch channel, and edited the metadata accordingly. Let me know if you think it's ready to merge! |
|
Looks good to me. Thanks for your contributions! |
I'll work on passing CircleCI tests, and will take another look through my code to see if there's anything else I wanted to point out, but I think for now I've highlighted the most notable comments.