[Closes #143] Resolve defaultProp and required prop warnings (#159)

* Remove use of defaultProps and replace with default values * Resolve undefined role prop warning * Format files
sfbrigade · Nov 7, 2024 · 6e40cb9 · 6e40cb9
1 parent 2a736bb
commit 6e40cb9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/client/src/App.jsx b/client/src/App.jsx
@@ -146,13 +146,17 @@ function App() {
             <Route
               path="/patients/register/:patientId"
               element={
-                <ProtectedRoute
-                  role={user?.role}
-                  restrictedRoles={['FIRST_RESPONDER']}
-                  message={'Patient does not exist.'}
-                >
-                  <PatientRegistration />
-                </ProtectedRoute>
+                user ? (
+                  <ProtectedRoute
+                    role={user?.role}
+                    restrictedRoles={['FIRST_RESPONDER']}
+                    message={'Patient does not exist.'}
+                  >
+                    <PatientRegistration />
+                  </ProtectedRoute>
+                ) : (
+                  <Loader />
+                )
               }
             />
 

diff --git a/client/src/stories/Header/Header.jsx b/client/src/stories/Header/Header.jsx
@@ -18,7 +18,7 @@ import { Sidebar } from '../../components/Sidebar/Sidebar';
  * Buttons for logged out buttons
  * @param {PropTypes.InferProps<typeof headerProps>} props
  */
-export function Header({ user }) {
+export function Header({ user = null }) {
   const [drawerOpened, { toggle: toggleDrawer, close: closeDrawer }] =
     useDisclosure(false);
 
@@ -74,9 +74,6 @@ const headerProps = {
 };
 
 Header.propTypes = headerProps;
-Header.defaultProps = {
-  user: null,
-};
 
 const loggedOutButtonsProps = {};