Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closes #132] Add additional information for the results of the Physician search #135

Merged
merged 23 commits into from
Oct 25, 2024

Conversation

codergirl01
Copy link
Contributor

Closes #132

This PR adds hospital name that the physician is connected with in the Physicians form search.

@samau3
Copy link
Contributor

samau3 commented Oct 4, 2024

I noticed there's a bug on the Register Patient form, where selecting a physician properly shows the hospital information. However, when the selection is submitted and the page is refreshed, the existing physician data is populated without the hospital information:

Screen Recording 2024-10-04 at 4 55 39 PM

Copy link
Contributor

@samau3 samau3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just one small change and a bug fix for the form and then we can have more distinction between physicians!

server/routes/api/v1/physicians/list.js Outdated Show resolved Hide resolved
Copy link
Contributor

@samau3 samau3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @codergirl01! I made some additional changes after pulling the code locally so feel free to review the new commits

@samau3 samau3 requested a review from francisli October 21, 2024 21:56
@francisli francisli merged commit 1fd9b26 into dev Oct 25, 2024
1 check passed
@francisli francisli deleted the issue-132 branch October 25, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional information for the results of the Physician search
3 participants