Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Closes #95] User can register through invite #99

Merged
merged 6 commits into from
Aug 26, 2024
Merged

[Closes #95] User can register through invite #99

merged 6 commits into from
Aug 26, 2024

Conversation

javtran
Copy link
Contributor

@javtran javtran commented Aug 9, 2024

#95

  • User can now accept invite on email and complete their registration
  • Registrations through invite do not require license number if role is not first responders
  • Invalid invite redirects back to /registration with notification of invalid invite.

@javtran javtran self-assigned this Aug 9, 2024
@javtran javtran linked an issue Aug 9, 2024 that may be closed by this pull request
User can accept an Invite to create an account #95
Closed
francisli
francisli requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@francisli francisli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but if the invited user is NOT a First Responder, I think we should hide the License Number field completely from the form.

client/src/pages/register/register.jsx Outdated Show resolved Hide resolved
@francisli francisli merged commit 51df2a9 into dev Aug 26, 2024
1 check passed
@francisli francisli deleted the 95-accept-invite branch August 26, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisli francisli francisli approved these changes

Assignees

@javtran javtran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User can accept an Invite to create an account
2 participants
@javtran @francisli