Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shader_recompiler: shaer patch to manualy normalize on unsupported Vulkan UNORM/SNORM formats #1532

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

LNDF
Copy link
Contributor

@LNDF LNDF commented Nov 14, 2024

Vulkan doesn't have support for SNORM/UNORM number formats for 32, 32_32, 32_32_32 and 32_32_32_32 data formats. Insteed use SINT/UINT and normalize/unormalize on shader when reading/writing.

Maybe we don't need to specialize by number of components, I can revert that.

@LNDF LNDF marked this pull request as ready for review November 15, 2024 16:49
@LNDF
Copy link
Contributor Author

LNDF commented Nov 15, 2024

Please verify that the patch is correct. I was not able to test it myself.

@kalaposfos13
Copy link
Contributor

In Beach Buggy Racing, it seems this does not work
shad_log_snorm_with.txt
shad_log_snorm_without.txt

@LNDF
Copy link
Contributor Author

LNDF commented Nov 15, 2024

This pr only covers 32 bit normalized numbers, does the game black screen?

@kalaposfos13
Copy link
Contributor

No the game works fine and is playable, other than no way of saving progress due to it storing data online

@MajorP93
Copy link
Contributor

MajorP93 commented Nov 28, 2024

@LNDF merged tesselation (PR 1528) and this PR on top of current main: (link to fork)
Unfortunately when trying to start "Stalker: Call of Pripyat" shadPS4 crashes after a few seconds.

Attached please find the log output.
shad_log.txt

Getting this to run can be really beneficial for further debugging / testing tesselation (aside from being able to run Stalker :D)

If I can provide additional information or help elsewhere in this regard please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants