Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siamese Network s43032053 #167

Open
wants to merge 32 commits into
base: topic-recognition
Choose a base branch
from

Conversation

richardchantra
Copy link

Dear COMP3710 teaching team,

Name: Richard Chantra
Student Number: s43032053
Project: #6 Siamese Network

I have 5 files for this project:
modules.py: Defines Siamese network, MLP classifier, loss functions, and evaluation
dataset.py: Manages data loading, augmentation, and data balancing
train.py: Trains the Siamese Network and MLP classifier
README.md: Project documentation

Thank you

…t.py and enabled pin_memory for GPU data transfer support
…cs including accuracy, ROC-AUC and classification report
…ger class to encapsulate data loading and configuration
…ecay in siamese network also fixed up image augmentations in dataset.py
…ch size to be 256 because there is GPU capacity
…odel what was previously performed in predict.py
… batch_size, epochs_siamese, epochs_mlp and save_dir for plots
@richardchantra richardchantra changed the title Richard Chantra Pull Request Siamese Network s43032053 Oct 27, 2024
@hanemma7moud
Copy link
Collaborator

hanemma7moud commented Nov 5, 2024

This is an initial inspection, no action is required at this point

Recognition Problem : total : 17

  1. Solves problem: The solution is appropriate for the problem but suffers from poor performance due to class imbalance and possibly an inadequate feature-extraction backbone.
    The resulting manifold is not well-separated.
    The classifier performs well in terms of overall accuracy, but:
    Sensitivity: Low at 32%, indicating poor performance in identifying malignant cases. (3)
    Recall: Excellent for benign cases at 99%, but only 1% for malignant cases.
    Different rebalancing strategies have been adopted, but further experimentation is needed to achieve balanced performance, particularly to improve the model's ability to classify malignant cases.

  2. Implementation functions as intended but A pre-trained ResNet is used for feature extraction (2)

  3. Good design: Well-designed (1)

  4. Commenting: Clear and sufficient comments throughout the code. (1)

  5. Difficulty: Hard (10)

Note:

  • A significant factor affecting the separation between classes might be the feature-extraction backbone’s strength and the chosen data balancing method.
  • Lack of Data Diversity: Resampling merely duplicates existing samples without adding new information, increasing the risk of overfitting, especially with small, diverse minority classes. In medical imaging, data diversity is essential for the model to learn robust, generalizable features.

@hanemma7moud hanemma7moud added the PDF PDF submitted label Nov 13, 2024
@gayanku
Copy link
Collaborator

gayanku commented Nov 14, 2024

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
Header blocks.
Recognition Problem
OK solution to problem. Model affected by imbalance.-3
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting present.
No Data leakage found. Has data splitting.
Difficulty : Hard. Siamese network (Hard Difficulty)
Commit Log
Good Meaningful commit messages.
Good Progressive commits.
Documentation
Readme :Good.
Model/technical explanation :Good.
Description and Comments :Acceptable. -1
Markdown used and PDF submitted. PDF Checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). On time.
Feedback action required: Feedback marks possible +2 if the requested changes are made. Merge conflicts due to changes to repo README files.-2
Request Description is adequate. -1
TOTAL-7

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

@gayanku
Copy link
Collaborator

gayanku commented Nov 14, 2024

Feedback marks possible +2 if the requested changes are made (see above).

@gayanku gayanku added Preliminary Grade To be confirmed after review. Feedback Needed Feedback needed for completion. labels Nov 14, 2024
@richardchantra
Copy link
Author

Done, thanks team!

@shakes76
Copy link
Owner

Cant merge because of conflicting changes to main repo files (LICENSE). Please update for merge, doesn't affect grade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB Completed Feedback Needed Feedback needed for completion. PDF PDF submitted Preliminary Grade To be confirmed after review. _Siamese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants