Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFNet for Alzheimers #172

Open
wants to merge 35 commits into
base: topic-recognition
Choose a base branch
from

Conversation

J-Ath1
Copy link

@J-Ath1 J-Ath1 commented Oct 29, 2024

GFNet for binary classification of Alzheimers and non-afflicted MRI scans.

Model:
The model uses the Global Filtering variety of a ViT to replace attention mechanisms by filtering global information across all spatial locations, allowing it to capture long-range dependencies more effectively than traditional ViTs. This approach aids in reducing redundant computations and improving focus on relevant spatial features.

J-Ath1 added 30 commits October 23, 2024 22:09
@wangzhaomxy
Copy link
Collaborator

<This is an initial inspection, no action is required at this point.>

File Organizing: Wrong file path. All student-constructed documents should be packed in the ‘PatternAnalysis-2024/recognition/<student_constructed_folder>/’ folder. Please reorganize your files, otherwise it won't be merged into Shakes' branch.

Problem Solving:

  • The algorithm solves the problem appropriately.
  • Accuracy in testing dataset: 0.68.

Model and functions:

  • It correctly uses PyTorch to construct the GFNet models and functions.
  • With data augmentation.

Code design: Good.

Code comment and docstring:

  • Good code comments
  • Good function docstrings

Difficulty: Hard.

Additional Comments:

  • intermediate numbers of commits
  • Good ReadMe design

@aniketgupta17
Copy link
Collaborator

Observational Feedback

Pull Request:
Correctly created the Pull request from Topic Recognition Branch .
The pull request includes NO description about the file structure .

File Organizing: Wrong file path. All student-constructed documents should be packed in the ‘PatternAnalysis-2024/recognition/<student_constructed_folder>/’ folder. Please reorganize your files, otherwise it won't be merged into Shakes' branch.

Commit Log:
Commit messages could be more progressive for the Recognition Problem solved using 4 files .
Commits show a logical Flow .

Documentation:

Code comments and docstrings are included.
Proper GitHub markdown formatting is used, with organized headings, lists, and code blocks.
Can add about future improvements and works in the ReadMe

@hanemma7moud hanemma7moud added the PDF PDF submitted label Nov 13, 2024
@gayanku
Copy link
Collaborator

gayanku commented Nov 13, 2024

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
No Header blocks. -1
Recognition Problem
Good solution to problem.
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage. Usage missing-1
Module present.
Commenting present.
No Data leakage found.
Difficulty : Hard. GFNet (Hard Difficulty)
Commit Log
Good Meaningful commit messages.
Some/Adequate Progressive commits. -1
Documentation
Readme :Good.
Model/technical explanation :Good.
Description and Comments :Good.
Markdown used and PDF submitted. PDF Checked.
Pull Request
Pull Request has problems. Initial PR used wrong branch. Last submission.-2
Feedback action required: Feedback marks possible +2 if the requested changes are made. Remove cache files for merge.-2
Request Description is good.
TOTAL-7

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

@gayanku gayanku added Preliminary Grade To be confirmed after review. Feedback Needed Feedback needed for completion. labels Nov 13, 2024
@gayanku
Copy link
Collaborator

gayanku commented Nov 13, 2024

Feedback marks possible +2 if the requested changes are made (see above).

@gayanku gayanku added the _After cutoff After Oct 28th label Nov 13, 2024
@hanemma7moud
Copy link
Collaborator

Jackson Athanasiadis

@shakes76
Copy link
Owner

Incorrect folder structure, should use own folder -2, feedback applied +2

@shakes76
Copy link
Owner

Cant merge because of conflicting changes to main repo files (README). Please update for merge, doesn't affect grade.

@shakes76 shakes76 added Completed Updated_Grade BB grade needs adjustment labels Nov 19, 2024
@shakes76
Copy link
Owner

Approved extension +2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_After cutoff After Oct 28th BB Completed Feedback Needed Feedback needed for completion. _GFNet PDF PDF submitted Preliminary Grade To be confirmed after review. Updated_Grade BB grade needs adjustment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants