Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s4879083 3d-unet #195

Open
wants to merge 26 commits into
base: topic-recognition
Choose a base branch
from

Conversation

Han1zen
Copy link

@Han1zen Han1zen commented Nov 20, 2024

No description provided.

@gayanku gayanku added _UNet3D _After cutoff After Oct 28th PDF PDF submitted labels Nov 20, 2024
@gayanku
Copy link
Collaborator

gayanku commented Nov 20, 2024

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
No design and implementation. -2
Spacing and comments.
No Header blocks. -1
Recognition Problem
OK solution to problem. Shown dice score in graph not consistant with reported score. Train loss > Validation loss looks incorrect. DL refer to files that’s not inlcude (ex:train_list.txt)-3
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting missing. No doc strings.-1
No Data leakage found.
Difficulty : Normal. UNet3D (Normal Difficulty)-5
Commit Log
Some/Adequate Meaningful commit messages. -1
Good Progressive commits. -2
Documentation
Readme :Acceptable. Some markup errors.-2
Model/technical explanation :Acceptable. Model details minimal. -1
Description and Comments :Acceptable. Usage instructions basic/has gaps.-1
Markdown used and PDF submitted. PDF submitted.
Pull Request
Pull Request has problems: Late submission.-2
No Feedback required.
Request Description is missing. Empty-2
TOTAL-23

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

@gayanku gayanku added Preliminary Grade To be confirmed after review. Commit Log labels Nov 20, 2024
@celinsze
Copy link
Collaborator

This is an initial inspection, no action is required at this point

Recognition problem:
Problem solving:
• Provided average Dice score of above 0.7 but with training and validation loss > 0.6 after final epoch.
• Dice score for individual label not provided for evaluation.
• No example output provided.
Algorithm implementation:
• Algorithm implemented in PyTorch for the UNet3D model and functions.
Design:
• Loss function defined but not used for testing (predict.py)
Commenting:
• Some comments throughout the code but missing comments for model
Difficulty: 3D UNet – Normal

@shakes76
Copy link
Owner

Additional -1 for late submission of PR, but all work done on time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_After cutoff After Oct 28th Commit Log Completed PDF PDF submitted Preliminary Grade To be confirmed after review. _UNet3D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants