Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thorchain LP useIsTradingActive / useGetEstimatedFeesQuery stop polling on Txid #6233

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Feb 17, 2024

Description

See #6168 (comment):

❓ Non blocking, but

  • Polling halted state continues after tx has been submitted
  • Gas rate polling continues after tx has been submitted

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

Low

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

  • Ensure estimate and inbound_addresses calls are still going through at LP deposit Tx sign step
  • Ensure polling stop once we have a Txid

Operations

  • ☝🏽

Screenshots (if applicable)

Screen.Recording.2024-02-17.at.08.04.25.mov

Copy link
Contributor Author

gomesalexandre commented Feb 17, 2024

@gomesalexandre gomesalexandre changed the title feat: thorchain LP useIsTradingActive / useGetEstimatedFeesQuery stop fetching on Txid feat: thorchain LP useIsTradingActive / useGetEstimatedFeesQuery stop polling on Txid Feb 17, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review February 17, 2024 15:21
@gomesalexandre gomesalexandre requested a review from a team as a code owner February 17, 2024 15:21
Base automatically changed from feat_lp_trading_active_improvements to develop February 18, 2024 23:56
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Ensure estimate and inbound_addresses calls are still going through at LP deposit Tx sign step
βœ… Ensure polling stop once we have a Txid

βœ… Sanity checked fees are still working as expected

@0xApotheosis 0xApotheosis merged commit bbdc285 into develop Feb 19, 2024
4 checks passed
@0xApotheosis 0xApotheosis deleted the feat_lp_trading_active_improvements_2 branch February 19, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants