fix: do not hardcode thorchain on trading active check #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
LGTM, confirmed this is indeed the guy (though will need to be propagated to all consumooors) - @0xApotheosis can we target this guy to release? 🙏🏽
gomesalexandre
force-pushed
the
fix-halted
branch
from
5549df8 to
4df4744
Compare
gomesalexandre
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the actual swapper name when checking if trading is active.
Pull Request Type
Issue (if applicable)
closes #6242 - fixes regression caused by #6168.
Risk
Small
In theory all swappers are affected by this change - we need to ensure we can still trade with them without misleading halted flags.
Testing
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
N/A