Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGSE に記載の OfferMessage 追加した項目名をキャメルケースに修正する #146

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

zztkm
Copy link
Contributor

@zztkm zztkm commented Dec 23, 2024

変更内容

OfferMessage に追加した項目と記載しているのに、項目の記載が offer message の json の項目名だったので、OfferMessage data class での項目名に修正しました。

リリース前の CHANGES の修正なので、この PR での CHANGES 追加はありません。


This pull request includes updates to the CHANGES.md file to standardize the naming conventions of several parameters. The most important changes are as follows:

Parameter naming standardization:

  • Changed simulcast_multicodec to simulcastMulticodec.
  • Changed channel_id to channelId.
  • Changed session_id to sessionId.
  • Changed audio_codec_type to audioCodecType.
  • Changed audio_bit_rate to audioBitRate.
  • Changed video_codec_type to videoCodecType.
  • Changed video_bit_rate to videoBitRate.

@zztkm zztkm requested a review from miosakuma December 23, 2024 09:49
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいところまですばらしい!ありがとうございます。

@zztkm zztkm merged commit cbf4c23 into develop Dec 24, 2024
@zztkm zztkm deleted the feature/fix-update-offermessage-changelog branch December 24, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants