Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_channels 項目に header 項目を追加 #104

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

torikizi
Copy link
Contributor

@torikizi torikizi commented Oct 29, 2024

data_channels 項目に header 項目を追加しました。
dc.header は string から json にパースして設定しています。


This pull request introduces a new Header property to the DataChannel class and updates related files to support this addition. The most important changes include updates to the Sora.Config, DataChannel class, and associated methods in both C# and C++ code, as well as the protocol buffer definition.

Enhancements to DataChannel:

  • Sora/Sora.cs: Added Header property to the DataChannel class.
  • Sora/Sora.cs: Updated Connect method to set the Header property if it is not null.

Protocol buffer updates:

C++ code updates:

  • src/sora.cpp: Updated DoConnect method to parse and set the Header property from JSON.

Documentation updates:

  • CHANGES.md: Documented the addition of the Header property to DataChannels.

@torikizi torikizi requested review from melpon and miosakuma October 29, 2024 01:46
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants