Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PO-489 - Add Github actions #42

Closed
wants to merge 2 commits into from
Closed

PO-489 - Add Github actions #42

wants to merge 2 commits into from

Conversation

mkraeml
Copy link
Contributor

@mkraeml mkraeml commented Sep 30, 2024

WIP

@mkraeml mkraeml force-pushed the po-489/add-github-actions branch 30 times, most recently from fe844ec to c118fdc Compare October 4, 2024 11:51
@mkraeml mkraeml force-pushed the po-489/add-github-actions branch 4 times, most recently from ca72618 to 41f10ee Compare October 11, 2024 14:57
@mkraeml mkraeml marked this pull request as ready for review October 15, 2024 15:06
philipreinken
philipreinken requested changes Oct 21, 2024
View reviewed changes
Copy link

@philipreinken philipreinken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 There are a few TODOs which should be resolved, I suppose.

@mstegmeyer
Copy link
Contributor

This would also need to be ported to 6.5.x, since we still have to support that version as well.

pweyck
pweyck reviewed Nov 21, 2024
View reviewed changes
.github/workflows/admin.yml Outdated Show resolved Hide resolved
@mkraeml mkraeml force-pushed the po-489/add-github-actions branch 9 times, most recently from 1ae3c23 to 55bf6c2 Compare November 26, 2024 10:12
@mkraeml mkraeml force-pushed the po-489/add-github-actions branch from 55bf6c2 to dc1b1b9 Compare November 26, 2024 10:33
@mkraeml mkraeml force-pushed the po-489/add-github-actions branch from dc1b1b9 to 5d982c3 Compare November 28, 2024 12:23
@mkraeml mkraeml force-pushed the po-489/add-github-actions branch from 5d982c3 to 93d25e1 Compare November 28, 2024 12:24
@mkraeml
Copy link
Contributor Author

mkraeml commented Dec 2, 2024

Already merged through Gitlab

@mkraeml mkraeml closed this Dec 2, 2024
@cyl3x cyl3x deleted the po-489/add-github-actions branch December 2, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pweyck pweyck pweyck approved these changes

@philipreinken philipreinken Awaiting requested review from philipreinken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkraeml @mstegmeyer @pweyck @philipreinken