Test: Add syntax tests and add missing use warnings

[nicomen]

A new dependency is introduced, but only while testing

[DarthGandalf]

Is the name supposed to start with ~?

[nicomen]

Just convention to let it be the first test to run, ~ is sorted before most other characters. We can use numbers or perhaps a testrules.yml file too. https://perldoc.perl.org/TAP::Harness#new (look for testrules.yml)

[nicomen]

Apparently it's ran last now :-D Maybe it's the last one. Oh well. We can rename it and just drop the ~. It's not that many tests that you want to fail fast.

[DarthGandalf]

That would be cleaner, yes.

Or at least please add a comment.

[DarthGandalf]

Btw, from "Add syntax tests" it was obvious enough that it's about tests :D

[DarthGandalf]

This is a private function of Test::Strict? It's not documented at https://metacpan.org/pod/Test::Strict

Why all_perl_files_ok was not enough?

[nicomen]

To run them in parallell. First it finds all files to test with _all_perl_files, then in the next part below it runs them in parallell, in this case 4 at a time. I could find "all perl-like" files myself, but thought it was best to use Test::Strict own way to find them.

This is just a standard syntax check I add in all projects.

When a project is big it gets slow to run syntax checks on all files sequentially.

[nicomen]

It can be just this:

#!/usr/bin/env perl

use strict;
use warnings;

use Test::More;
use Test::Strict;

use FindBin qw/$Bin/;

# Check syntax, use strict and use warnings on all perl files

local $Test::Strict::TEST_WARNINGS = 1;

my @dirs  = ('t', 'bin', "$Bin/../share/shutter/resources/modules/");

all_perl_files_ok(@dirs);

done_testing;

Locally that takes 10 seconds vs 4 seconds in parallell.

If you prefer I can use the "simple" approach instead.

[DarthGandalf]

10 seconds is good enough. Additional 6 seconds don't deserve the added complexity