Improve builder ergonomics, remove prefix #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements for ergonomics
new("v4")
provides little value taking into accountv4
is the only supported identity scheme. So just implementDefault
for the builder instead,BuilderOfX
viaX::builder
since that's an easily avoidable import, so nowEnr
provides:Enr::builder()
Enr
. This would beEnrBuilder::new().build(&key)
, there is a friendly shortcut for thisEnr::empty
Enr
prefix fromEnrBuilder
this shouldn't be even needed to import thanks to theEnr::builder
andEnr::empty
Notes
Tests don't use the most ergonomic versions of the builder in their current form (before this change). Since test setup is most of the time done by copying the setup from a related test, I updated them all to use the most appropriate, ergonomic version of what they had
Also, there is a clippy failure but I don't think having those warnings enabled makes sense: