feat: add pdb to policy-controller #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobyMCbobs
force-pushed
the
add-pdb-to-policy-controller
branch
from
39bcab4 to
9a0fd36
Compare
Signed-off-by: Caleb Woodbine <[email protected]>
BobyMCbobs
force-pushed
the
add-pdb-to-policy-controller
branch
from
9a0fd36 to
5cb2277
Compare
vaikas
approved these changes
Sep 13, 2023
| podDisruptionBudget: | ||
| enabled: true | ||
| minAvailable: 1 | ||
| # maxUnavailable: 3 |
There was a problem hiding this comment.
Nit: Is this left here on purpose?
There was a problem hiding this comment.
If this value is not set here it will be empty and unexpressed in the actual resource.
This is a pattern that's used in a lot of places, though happy to consider alternatives!
There was a problem hiding this comment.
Yeah, I'm not an helm expert, and saw it commented out, and wasn't sure if it was just left over from developing, so figured I'd ask :)
|
@vaikas, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a PodDisruptionBudget for the webhook deployment
Additional Information
Enhances availability, especially when using multiple replicas
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.