Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClusterRole name to be based on SA name #620

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Oct 4, 2023

Description of the change

If you look in rolebindings.yaml alongside this file you will see that the way this role is consumed is via this templated name, but the name isn't actually templated!

Existing or Associated Issue(s)

N/A

Additional Information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

If you look in `rolebindings.yaml` alongside this file you will see that the way this role is consumed is via this templated name, but the name isn't actually templated!

Signed-off-by: Matt Moore <[email protected]>
@priyawadhwa priyawadhwa merged commit 20cc9a8 into sigstore:main Oct 4, 2023
2 checks passed
@mattmoor mattmoor deleted the fix-cluster-role branch October 4, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants