Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop 1.27/28 and add 1.30/31/32 k8s #1745

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 19, 2024

No description provided.

@cpanato cpanato requested review from hectorj2f and vaikas December 19, 2024 16:27
@cpanato cpanato marked this pull request as ready for review December 19, 2024 16:27
@cpanato
Copy link
Member Author

cpanato commented Dec 19, 2024

if approved we need to update the GH checks, i will do that

vaikas
vaikas previously approved these changes Dec 20, 2024
Copy link
Collaborator

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cpanato !!

@hectorj2f
Copy link
Collaborator

Thanks

@vaikas
Copy link
Collaborator

vaikas commented Dec 20, 2024

Tuf root expired 🤣

--- FAIL: TestClientFromSerializedMirror (0.00s)
    repo_test.go:206: Failed to unserialize repo: failed to update TUF client: tuf: failed to decode root.json: expired at 2024-12-18 18:47:22 +0000 UTC

@hectorj2f
Copy link
Collaborator

Tuf root expired like on every 🎄🎁.

Signed-off-by: cpanato <[email protected]>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.77%. Comparing base (50ef092) to head (97654cc).
Report is 291 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1745       +/-   ##
===========================================
- Coverage   52.92%   42.77%   -10.16%     
===========================================
  Files          44      121       +77     
  Lines        3979     8987     +5008     
===========================================
+ Hits         2106     3844     +1738     
- Misses       1651     4788     +3137     
- Partials      222      355      +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpanato
Copy link
Member Author

cpanato commented Dec 20, 2024

update checks sigstore/community#525

@hectorj2f
Copy link
Collaborator

@cpanato we need to change the Ci checks is expecting k8s 1.28 and 1.27.

@cpanato
Copy link
Member Author

cpanato commented Dec 20, 2024

@cpanato we need to change the Ci checks is expecting k8s 1.28 and 1.27.

yes, pr is here sigstore/community#525

@cpanato cpanato merged commit 6d45cdb into sigstore:main Dec 20, 2024
73 of 74 checks passed
@cpanato cpanato deleted the update-k8s-tests branch December 20, 2024 14:18
@github-actions github-actions bot added this to the v1 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants