Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename rekor createsecret to eliminate naming confict #1221

Merged
merged 1 commit into from
Aug 13, 2024
Merged

rename rekor createsecret to eliminate naming confict #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ prober
/createctconfig
/createdb
/createsecret
/rekor-createsecret
/createtree
/getoidctoken
/managectroots
Expand Down
2 changes: 1 addition & 1 deletion .ko.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ builds:

- id: rekor-createsecret
dir: .
main: ./cmd/rekor/createsecret
main: ./cmd/rekor/rekor-createsecret
env:
- CGO_ENABLED=0
flags:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ build-getoidctoken:

.PHONY: build-rekor-createsecret
build-rekor-createsecret:
go build -trimpath ./cmd/rekor/createsecret
go build -trimpath ./cmd/rekor/rekor-createsecret

.PHONY: build-trillian-createdb
build-trillian-createdb:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ have the following (some stuff omitted for readability) in our Rekor Deployment
to ensure that Rekor will not start prior to TreeID having been properly
provisioned.
Rekor also needs a Signing Key that it will use, and we create one with
[CreateSecret](./cmd/rekor/createsecret/main.go). It will create two secrets,
[CreateSecret](./cmd/rekor/rekor-createsecret/main.go). It will create two secrets,
one holding the Private Signing key as well as the password used to encrypt it
with. By default the secret is named `rekor-signing-secret` and contains two
keys:
Expand Down
2 changes: 1 addition & 1 deletion cmd/rekor/createsecret/main.go → cmd/rekor/rekor-createsecret/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func main() {

ctx := signals.NewContext()
versionInfo := version.GetVersionInfo()
logging.FromContext(ctx).Infof("running createsecret Version: %s GitCommit: %s BuildDate: %s", versionInfo.GitVersion, versionInfo.GitCommit, versionInfo.BuildDate)
logging.FromContext(ctx).Infof("running rekor-createsecret Version: %s GitCommit: %s BuildDate: %s", versionInfo.GitVersion, versionInfo.GitCommit, versionInfo.BuildDate)

config, err := rest.InClusterConfig()
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion config/rekor/createsecret/300-createsecret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
automountServiceAccountToken: true
containers:
- name: createsecret
image: ko://github.com/sigstore/scaffolding/cmd/rekor/createsecret
image: ko://github.com/sigstore/scaffolding/cmd/rekor/rekor-createsecret
env:
- name: NAMESPACE
valueFrom:
Expand Down
Loading