Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create announcing-sigstore-java-1-0.md #65

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

loosebazooka
Copy link
Member

@loosebazooka loosebazooka commented Aug 21, 2024

Just prepping for sigstore-java 1.0 (we haven't released yet).

@loosebazooka loosebazooka requested review from a team as code owners August 21, 2024 17:20
@haydentherapper
Copy link
Contributor

trevrosen
trevrosen previously approved these changes Aug 22, 2024
Copy link
Contributor

@trevrosen trevrosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice post - congrats on the ship! 🎉

@loosebazooka loosebazooka dismissed stale reviews from trevrosen and haydentherapper via eaea91a August 22, 2024 13:21
loosebazooka and others added 2 commits August 22, 2024 09:21
@bobcallaway
Copy link
Member

LGTM (needs date and draft status fixed once release goes live)

@loosebazooka
Copy link
Member Author

will update here when release is done

@loosebazooka
Copy link
Member Author

loosebazooka commented Aug 27, 2024

Hrmm, looks like I need three reviews: anyone got a second to take another look? @bobcallaway @priyawadhwa @lukehinds @SantiagoTorres @trevrosen

NOTE: release is not out yet.

bobcallaway
bobcallaway previously approved these changes Aug 27, 2024
priyawadhwa
priyawadhwa previously approved these changes Aug 28, 2024
Release is done, update metadata

Signed-off-by: Appu <[email protected]>
@loosebazooka loosebazooka dismissed stale reviews from priyawadhwa and bobcallaway via aa568bf August 28, 2024 19:14
@bobcallaway bobcallaway merged commit 2b828ef into sigstore:main Aug 28, 2024
2 checks passed
@loosebazooka
Copy link
Member Author

release is done, thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants