Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test, tools: init bundle cert chain tests #78

Merged
merged 9 commits into from
May 27, 2023
Merged

test, tools: init bundle cert chain tests #78

merged 9 commits into from
May 27, 2023

Conversation

tnytown
Copy link
Collaborator

@tnytown tnytown commented May 4, 2023

Resolves #66.

@tnytown tnytown marked this pull request as ready for review May 5, 2023 20:20
tnytown added 3 commits May 8, 2023 16:04
@tnytown
mypy.ini: checkin
4a67276 
Signed-off-by: Andrew Pan <[email protected]>
@tnytown
treewide: remove ski/aki test
567dd69 
Signed-off-by: Andrew Pan <[email protected]>
@tnytown
conftest: re-add --identity-token
c2bb326 
Fixes bad merge in sigstore#69.

Signed-off-by: Andrew Pan <[email protected]>
@tnytown tnytown force-pushed the ap/issue/66 branch 4 times, most recently from 07a7632 to 1f15a08 Compare May 9, 2023 17:43
@tnytown tnytown requested a review from woodruffw May 9, 2023 17:51
@tnytown
Copy link
Collaborator Author

tnytown commented May 9, 2023

#69 introduced a flake that we didn't catch because the self-tests ran against the base branch w/ pull_request_target. It should be safe to run PR code now that we've dropped the ambient credential, so I've adjusted our self-test to run against the PR branch with pull_request.

woodruffw
woodruffw previously approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; we should get the improved bundle check PR in sigstore-python merged in and then merge this.

@tetsuo-cpp tetsuo-cpp mentioned this pull request May 26, 2023
Merged
@woodruffw woodruffw merged commit 7a0018a into sigstore:main May 27, 2023
@woodruffw woodruffw deleted the ap/issue/66 branch May 27, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle test cases
2 participants
@tnytown @woodruffw