Fix implicit cast from long to int (apache#4209)

Fix implicit cast from long to int
sijie · Jul 12, 2024 · b3b545a · b3b545a
1 parent c1b5b35
commit b3b545a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...er-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LedgerMetadataIndex.java b/...er-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LedgerMetadataIndex.java
@@ -352,7 +352,7 @@ public void removeDeletedLedgers() throws IOException {
     }
 
     private ReentrantLock lockForLedger(long ledgerId) {
-        return locks[Math.abs((int) ledgerId) % locks.length];
+        return locks[(int) (Math.abs(ledgerId) % locks.length)];
     }
 
     int getStorageStateFlags() throws IOException {

diff --git a/...dahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/codahale/FastTimer.java b/...dahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/codahale/FastTimer.java
@@ -289,7 +289,7 @@ public FastTimer(int timeWindowSeconds, Buckets buckets) {
         // initialize buckets
         int bucketCnt = 0;
         for (int i = 0; bucketSpec != null && i < bucketSpec.length; i++) {
-            bucketCnt += bucketSpec[i][BS_NUMBUCKETS];
+            bucketCnt += (int) bucketSpec[i][BS_NUMBUCKETS];
         }
         numBuckets = (bucketCnt > 0 ? bucketCnt + 1 : 0);
         if (numBuckets > 0) {
@@ -349,7 +349,7 @@ public int getBucket(long duration) {
             if (duration <= bucketBounds[i]) {
                 return bucket + (int) ((duration - lowbound - 1) / bucketSpec[i][BS_RESOLUTION]);
             } else {
-                bucket += bucketSpec[i][BS_NUMBUCKETS];
+                bucket += (int) bucketSpec[i][BS_NUMBUCKETS];
                 lowbound = bucketBounds[i];
             }
         }
@@ -371,7 +371,7 @@ public long getBucketBound(int b) {
             if (b < bucket + bucketSpec[i][BS_NUMBUCKETS]) {
                 return lowbound + ((long) ((b + 1) - bucket)) * bucketSpec[i][BS_RESOLUTION];
             } else {
-                bucket += bucketSpec[i][BS_NUMBUCKETS];
+                bucket += (int) bucketSpec[i][BS_NUMBUCKETS];
                 lowbound = bucketBounds[i];
             }
         }