-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Update JS MIME type, remove type
in <script>
, fix few typos
#632
Conversation
01403f6
to
c6d82e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Some suggested changes to wording below.
c6d82e3
to
4b36d27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have asked for this last time, but can you please also prefix the commit message with DOC
as per https://docs.silverstripe.org/en/5/contributing/code/#commit-messages
4b36d27
to
2479728
Compare
type
in <script>
silverstripe/silverstripe-framework/pull/11446, fix few typos
type
in <script>
silverstripe/silverstripe-framework/pull/11446, fix few typostype
in <script>
, fix few typos
2479728
to
e3a0926
Compare
e3a0926
to
1bd9c2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Description
Update JS MIME type, remove type in <script> silverstripe/silverstripe-framework#11446, fix few typos
Issues
Pull request checklist