Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Use FieldValidator for FormFields #1345

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft October 31, 2024 23:36
@emteknetnz emteknetnz force-pushed the pulls/7/form-field-valid branch 4 times, most recently from d7781a2 to 7a70cd5 Compare November 12, 2024 00:26
@emteknetnz emteknetnz marked this pull request as ready for review November 14, 2024 22:07
@emteknetnz emteknetnz force-pushed the pulls/7/form-field-valid branch 2 times, most recently from 4128942 to f664c2b Compare November 21, 2024 05:15
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all PRs are ready

@emteknetnz emteknetnz force-pushed the pulls/7/form-field-valid branch from f664c2b to 2b9c6cc Compare November 26, 2024 04:31
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 0020f7d into silverstripe:7 Dec 2, 2024
7 of 11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/7/form-field-valid branch December 2, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants