Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposals #40

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Proposals #40

merged 4 commits into from
Jul 4, 2024

Conversation

sjuergen
Copy link
Contributor

No description provided.

Comment on lines -27 to -28
dependencies:
"@ax/system": 7.0.17 # this is an example lib-dependency for your code, pls. adjust
Copy link
Contributor

@BeckerStS BeckerStS Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added that because otherwise (no dependencies section) by adding new dependencies they will always be generated at the buttom of the apax.yml. Having them already next to the devdependencies (by default) makes a better look an feel in the end if noone deosn't care about the pattern.
But hey, I'am fine of leaving it out as well ... if you wish.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For many reasons it's acceptable that the dependency section is at the end of the file. Or is there any reasonable pain? For my opinion it's more annoying to delete unused dependencies afterwards (especially including the complete system library which blows up your project unnecessarily).

Copy link
Contributor

@BeckerStS BeckerStS Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reasonal pain having it or leaving it as it is ... Iam fine of deleting it again.
MR can be merged :)

@sjuergen sjuergen merged commit 52b9106 into add/changelog Jul 4, 2024
3 checks passed
@sjuergen sjuergen deleted the proposals branch July 4, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants