Fix bug in slice fixes

simonkellly · May 22, 2024 · 182b636 · 182b636
1 parent a439417
commit 182b636
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/lib/solutionParser.ts b/src/lib/solutionParser.ts
@@ -78,7 +78,7 @@ function applyRotation(rotation: string, move: string) {
   return result;
 }
 
-function fixSlicesForComm(alg: Alg, puzzle: KPuzzle) {
+export function fixSlicesForComm(alg: Alg, puzzle: KPuzzle) {
   const transformation = puzzle.algToTransformation(alg);
   const centerPermutations =
     transformation.transformationData['CENTERS'].permutation;
@@ -109,8 +109,8 @@ function fixSlicesForComm(alg: Alg, puzzle: KPuzzle) {
   let newMoves: string[] | undefined;
   for (let i = moves.length - 1; i >= 0; i--) {
     const move = moves[i];
-    const isFirst = move[0] == neededMove[0];
-    const isSecond = move[0] == neededMove[1];
+    const isFirst = move == neededMove[0];
+    const isSecond = move == neededMove[1];
     if (isFirst || isSecond) {
       const altMove = isFirst ? neededMove[1] : neededMove[0];
       const oppositeMove =

diff --git a/tests/parse.test.ts b/tests/parse.test.ts
@@ -90,4 +90,12 @@ describe('Extract Comms', () => {
     expect(extracted.length).toBe(1);
     expect(extracted[0][0]).toBe("[U' M: [U', R' E R]]");
   });
+
+  test('Extract slice alg (RI) with wide move canceling', async () => {
+    const extracted = await extractAlgs(
+      "R U R' U' R' L F R F' L'".split(' ')
+    );
+    expect(extracted.length).toBe(1);
+    expect(extracted[0][0]).toBe("[R: [U R' U', M']]");
+  });
 });