Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/44: Define SERVER_NAME if ampWebAddress is empty #45

Open
wants to merge 3 commits into
base: release/16.0
Choose a base branch
from
Open

issues/44: Define SERVER_NAME if ampWebAddress is empty #45

wants to merge 3 commits into from

Conversation

vsc55
Copy link
Contributor

@vsc55 vsc55 commented Apr 21, 2024

No description provided.

@vsc55 vsc55 mentioned this pull request Apr 21, 2024
Open
@billsimon
Copy link
Contributor

Thanks @vsc55 ! I'll review it soon. Looks like a good idea. We use the ampwebaddress for MMS payloads too. I wonder whether that can be improved also.

@vsc55
Copy link
Contributor Author

vsc55 commented Jul 20, 2024

Hi @billsimon,
I have reviewed the module code and I don't see where else ampwebaddress is used.
Where in the code do you mean by "mms payloads too"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsc55 @billsimon