Fix misleading error message for epsilon values #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `BaseEM` class, epsilon properties are allowed to be zero or positive, although the error message stated that epsilon should be greater than zero. Fix the error message to agree with the implemented logic and also print the offending value.
santisoler
commented
Sep 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage ? 87.47%
=======================================
Files ? 29
Lines ? 3043
Branches ? 0
=======================================
Hits ? 2662
Misses ? 381
Partials ? 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
BaseEMclass, epsilon properties are allowed to be zero orpositive, although the error message stated that epsilon should be
greater than zero. Fix the error message to agree with the implemented
logic and also print the offending value.