Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy dependency fallback necessary for cross-compilation builds #77

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

jcapriot
Copy link
Member

Most cross-compilation builds are not able to make use of meson's numpy_config script to find the necessary header files, (See conda-forge/geoana-feedstock#34 where I was testing this before releasing a new version.)

I wasn't quite sure if it was able to do it or not (but I suspected it wasn't). So this adds a fallback method of determining the numpy include directory incase the normal lookup fails. So this addition follows what pywt does. (see here: https://github.com/PyWavelets/pywt/blob/361cc9a4c80bc2603fae99e151f2a391c0b376f9/pywt/_extensions/meson.build#L13)

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.88%. Comparing base (979cf23) to head (e9a7d8d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   85.88%   85.88%           
=======================================
  Files          31       31           
  Lines        3139     3139           
=======================================
  Hits         2696     2696           
  Misses        443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot jcapriot merged commit 179c191 into simpeg:main Oct 22, 2024
6 checks passed
@jcapriot jcapriot deleted the cross-compilation-build branch October 22, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant