Ensure the attribute name matches the NameFormat

simplesamlphp · Jul 19, 2024 · afae4f3 · afae4f3
1 parent 65a67f6
commit afae4f3
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/SAML2/XML/saml/Attribute.php b/src/SAML2/XML/saml/Attribute.php
@@ -51,6 +51,12 @@ public function __construct(
         Assert::maxCount($attributeValue, C::UNBOUNDED_LIMIT);
         Assert::allIsInstanceOf($attributeValue, AttributeValue::class, 'Invalid AttributeValue.');
 
+        if ($nameFormat === C::NAMEFORMAT_URI) {
+            Assert::validURI($name, "Attribute name does not match its declared format");
+        } elseif ($nameFormat === C::NAMEFORMAT_BASIC) {
+            Assert::validNCName($name, "Attribute name does not match its declared format");
+        }
+
         $this->setAttributesNS($namespacedAttribute);
     }