Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add support for Visium v1 #3510

Merged
merged 3 commits into from
Jan 3, 2025
Merged

[python] Add support for Visium v1 #3510

merged 3 commits into from
Jan 3, 2025

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Jan 2, 2025

Issue and/or context: sc-61280

Changes:

  1. Explicitly set header columns for
  2. Throw error if Visium version number is unknown.
  3. Make check for Visium filename version specific (this can be over-ridden by the user).

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 86.27%. Comparing base (11ee34c) to head (df48f2a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   86.27%   86.27%   -0.01%     
==========================================
  Files          55       55              
  Lines        6340     6344       +4     
==========================================
+ Hits         5470     5473       +3     
- Misses        870      871       +1     
Flag Coverage Δ
python 86.27% <21.05%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.27% <21.05%> (-0.01%) ⬇️
libtiledbsoma ∅ <ø> (∅)

Copy link
Collaborator

@ktsitsi ktsitsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a misc in the comment.

if tissue_positions is None:
major_version = version[0] if isinstance(version, tuple) else version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the property instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class wasn't created yet.

@jp-dark jp-dark merged commit 7addb3e into main Jan 3, 2025
11 checks passed
@jp-dark jp-dark deleted the dark/sc-61280 branch January 3, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants