[das-atom-db/#199] [HOTFIX] Deep copy atoms in LazyQueryEvaluator #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: singnet/das-atom-db#199
Together with singnet/das-atom-db#200 , this PR moves the deep copy being made in ram_only.get_atom() to inside LazyQueryEvaluator. This is not a proper solution because LazyQueryEvaluator is being called not only with ram_only but also with redis_mongo. But, on the other hand, LazyQueryEvaluator is one of the many classes being refactored in the context of singnet/das#73 so this issue will be revisited with more context information very soon. For now we'll pay the price of degrading performance with this deep copy since it's required in order to make proper implementation of DAS.get_atom() as implemented in #322 and singnet/das-atom-db#196