Remove duplication of parameter passing #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mabredin
commented
Jun 20, 2024
mabredin
commented
- Change CLI version in dependencies
- Change how parameters are passed
Change how parameters are passed
kiruxaspb
approved these changes
Jun 20, 2024
Deralden
added a commit
that referenced
this pull request
Jun 20, 2024
* Rewritten the test_sdk_client.py using unittest library, commented out clearly broken tests that need to be updated, replaced or removed * Added force_update key to config * Commented out the tests that are currently duplicate * Added automatic proto and pb2 files removal after running the test, uncommented the channel opening * Commented out tests that are under development * Add network change and identity functionality * Moved private keys to environment variables * Github actions implementation_dev (#47) * push actual test_sdk_client.py version to the dev branch * yml * Rename main.yml to master.yml * Update reset_environment.sh * Update run_all_functional.sh * Update reset_environment.sh * Update dev.yml * Update dev.yml * Update master.yml * Update reset_environment.sh * test * Update master.yml * Update dev.yml --------- Co-authored-by: Pavel Yagunov <[email protected]> Co-authored-by: Valery Geraskin <[email protected]> Co-authored-by: PAY2109 <[email protected]> * Change CLI version in dependencies (#48) Change how parameters are passed * Removed the test code that is currently not relevant, updated the readme (#43) * README.md update * Added network and force_update options to the test_sdk_client.py config dict * Removed the currently unused code from the test_sdk_client.py * Removed the tests that are currently not relevant * Added deposit to the test_sdk_client.py * Updated the README.md: added the config options description, removed the need to use CLI for MPE deposit operation * Removed the info about CLI usage for MPE deposit action * Fixed token name typo * Updated README.md and test_sdk_client.py according to the latest functionality changes * test_sdk_client.py: optimized config dict * Restored the config file --------- Co-authored-by: Pavel Yagunov <[email protected]> Co-authored-by: Maxim Bredin <[email protected]> * Upgrade version --------- Co-authored-by: Pavel Yagunov <[email protected]> Co-authored-by: mabredin <[email protected]> Co-authored-by: Maxim Bredin <[email protected]> Co-authored-by: Deralden <[email protected]> Co-authored-by: Valery Geraskin <[email protected]> Co-authored-by: PAY2109 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.