Add Bayesian estimate of transport coefficients #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikigigi
reviewed
Dec 27, 2024
| @@ -236,8 +237,9 @@ def compute_psd(self, PSD_FILTER_W=None, freq_units='THz'): | |||
| # number of degrees of freedom of the chi-square distribution of the psd / 2 | |||
| self.ndf_chi = self.N_EQUIV_COMPONENTS - self.N_CURRENTS + 1 | |||
| if self.ndf_chi <= 0: | |||
| raise RuntimeError('The number of degrees of freedom of the chi-squared distribution is <=0. The number of ' | |||
| 'equivalent (Cartesian) components of the input current must be >= number of currents.') | |||
| warnings.warn('The number of degrees of freedom of the chi-squared distribution is <=0. The number of ' | |||
There was a problem hiding this comment.
@ppegolo this means that the bayesian filter works also when we have fewer independent time series than the number of components?
|
continuing the development here: https://github.com/sissaschool/sportran/tree/ppegolo/bayes |
|
obsolete. Continuing in #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.